Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix](becore) has to use value to capture lambda value to avoid core during callback #32132

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[bugfix](becore) has to use value to capture lambda value to avoid core during callback #32132

merged 1 commit into from
Mar 12, 2024

Conversation

yiguolei
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@yiguolei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 36323 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a3fdd7aeb5ce9e5afe03093a53bfdf0732da9f38, data reload: false

------ Round 1 ----------------------------------
q1	17636	4209	4076	4076
q2	2040	155	153	153
q3	10556	935	884	884
q4	4658	665	655	655
q5	7575	2703	2778	2703
q6	188	126	129	126
q7	1209	835	809	809
q8	9473	2016	2024	2016
q9	7287	6452	6425	6425
q10	8167	2477	2481	2477
q11	426	213	210	210
q12	787	306	295	295
q13	17963	2990	3012	2990
q14	269	245	244	244
q15	490	462	449	449
q16	511	400	396	396
q17	939	508	545	508
q18	6509	5910	5731	5731
q19	1585	1389	1411	1389
q20	542	271	270	270
q21	7361	3224	3453	3224
q22	795	293	305	293
Total cold run time: 106966 ms
Total hot run time: 36323 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4096	4059	4085	4059
q2	319	221	221	221
q3	2930	2816	2809	2809
q4	1847	1555	1560	1555
q5	5189	5240	5250	5240
q6	193	116	123	116
q7	2238	1865	1828	1828
q8	3122	3282	3234	3234
q9	8504	8574	8645	8574
q10	6199	3630	3623	3623
q11	514	426	445	426
q12	713	569	515	515
q13	12090	2879	2863	2863
q14	282	237	255	237
q15	486	437	456	437
q16	456	419	409	409
q17	1721	1479	1460	1460
q18	7653	7157	7018	7018
q19	3046	1498	1528	1498
q20	1875	1699	1699	1699
q21	4919	4609	4600	4600
q22	540	444	463	444
Total cold run time: 68932 ms
Total hot run time: 52865 ms

HappenLee
HappenLee approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.97% (8555/24465)
Line Coverage: 26.81% (69527/259319)
Region Coverage: 26.07% (36085/138441)
Branch Coverage: 23.03% (18445/80090)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a3fdd7aeb5ce9e5afe03093a53bfdf0732da9f38_a3fdd7aeb5ce9e5afe03093a53bfdf0732da9f38/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 185995 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a3fdd7aeb5ce9e5afe03093a53bfdf0732da9f38, data reload: false

query1	910	354	343	343
query2	7863	2005	1905	1905
query3	6703	213	214	213
query4	31023	20504	20508	20504
query5	4324	400	407	400
query6	266	172	173	172
query7	4622	287	285	285
query8	236	168	166	166
query9	9856	2242	2202	2202
query10	465	235	240	235
query11	16915	14200	14354	14200
query12	136	89	78	78
query13	1628	416	431	416
query14	11785	10144	10700	10144
query15	266	213	185	185
query16	8086	260	253	253
query17	1943	534	522	522
query18	2081	269	278	269
query19	244	155	151	151
query20	90	78	81	78
query21	192	123	121	121
query22	4668	4470	4412	4412
query23	31879	31170	31036	31036
query24	10770	2860	2831	2831
query25	635	403	378	378
query26	1272	153	160	153
query27	2571	351	343	343
query28	7653	1841	1836	1836
query29	893	647	624	624
query30	303	151	148	148
query31	981	724	730	724
query32	97	61	56	56
query33	770	264	256	256
query34	1057	471	486	471
query35	813	591	610	591
query36	1005	872	860	860
query37	121	75	74	74
query38	3312	3163	3135	3135
query39	1421	1341	1384	1341
query40	204	115	112	112
query41	50	46	50	46
query42	102	94	126	94
query43	486	453	458	453
query44	1260	704	688	688
query45	284	265	245	245
query46	1098	690	685	685
query47	1644	1609	1573	1573
query48	447	345	347	345
query49	1127	340	337	337
query50	761	365	364	364
query51	6744	6754	6637	6637
query52	111	92	93	92
query53	344	270	282	270
query54	312	233	245	233
query55	83	78	77	77
query56	247	225	237	225
query57	1103	1001	1024	1001
query58	229	203	204	203
query59	2908	2696	2768	2696
query60	271	263	248	248
query61	112	113	111	111
query62	594	418	398	398
query63	298	269	268	268
query64	5743	3962	3952	3952
query65	3055	3013	2993	2993
query66	839	337	331	331
query67	14792	14263	14259	14259
query68	6878	511	514	511
query69	616	371	373	371
query70	1258	1176	1150	1150
query71	541	279	276	276
query72	6575	2667	2508	2508
query73	727	307	312	307
query74	7101	6584	6486	6486
query75	9224	7878	8007	7878
query76	4945	901	926	901
query77	669	278	256	256
query78	10320	9608	9562	9562
query79	10044	515	531	515
query80	1592	381	372	372
query81	510	206	205	205
query82	831	208	198	198
query83	215	151	147	147
query84	293	78	77	77
query85	1471	337	322	322
query86	416	280	303	280
query87	3378	3253	3196	3196
query88	4946	2270	2265	2265
query89	512	366	367	366
query90	2034	179	170	170
query91	156	133	151	133
query92	62	46	47	46
query93	6824	488	486	486
query94	1208	180	174	174
query95	428	341	324	324
query96	625	266	264	264
query97	4437	4249	4272	4249
query98	227	205	210	205
query99	1123	762	748	748
Total cold run time: 315289 ms
Total hot run time: 185995 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.74 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a3fdd7aeb5ce9e5afe03093a53bfdf0732da9f38, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.66	0.10	0.10
query5	0.52	0.50	0.49
query6	1.19	0.62	0.62
query7	0.02	0.02	0.01
query8	0.05	0.03	0.02
query9	0.55	0.51	0.49
query10	0.54	0.55	0.54
query11	0.12	0.09	0.09
query12	0.11	0.09	0.10
query13	0.56	0.56	0.56
query14	0.73	0.79	0.77
query15	0.79	0.77	0.80
query16	0.40	0.39	0.39
query17	0.99	0.96	0.94
query18	0.19	0.27	0.24
query19	1.78	1.69	1.76
query20	0.01	0.02	0.02
query21	15.41	0.57	0.56
query22	2.96	1.90	1.41
query23	17.36	0.82	0.66
query24	3.46	1.08	2.25
query25	0.13	0.22	0.07
query26	0.71	0.11	0.12
query27	0.03	0.03	0.04
query28	9.83	0.92	0.84
query29	12.53	3.13	3.21
query30	0.63	0.56	0.56
query31	2.80	0.32	0.35
query32	3.38	0.44	0.45
query33	2.84	2.81	2.77
query34	16.26	4.29	4.23
query35	4.29	4.28	4.33
query36	1.07	1.00	1.00
query37	0.07	0.05	0.05
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.14
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.68 s
Total hot run time: 29.74 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit a3fdd7aeb5ce9e5afe03093a53bfdf0732da9f38 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       16.6 seconds inserted 10000000 Rows, about 602K ops/s

@yiguolei yiguolei merged commit 4c775a6 into apache:master Mar 12, 2024
25 of 30 checks passed
yiguolei added a commit that referenced this pull request Mar 12, 2024
@yiguolei @Doris-Extras
[bugfix](becore) has to use value to capture lambda value to avoid co…
5da7cd0 
…re during callback (#32132)

Co-authored-by: yiguolei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacktengg jacktengg jacktengg approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yiguolei @doris-robot @HappenLee @jacktengg @Doris-Extras